BUG: Fix pcolormesh with nan inputs and wrapping#1847
Merged
greglucas merged 2 commits intoSciTools:masterfrom Sep 13, 2021
Merged
BUG: Fix pcolormesh with nan inputs and wrapping#1847greglucas merged 2 commits intoSciTools:masterfrom
greglucas merged 2 commits intoSciTools:masterfrom
Conversation
Contributor
|
Yes this fixes my issue - thanks for the fast response and PR! |
dopplershift
reviewed
Sep 9, 2021
QuLogic
approved these changes
Sep 10, 2021
nan inputs to pcolormesh combined with a wrap would mask out the data before getting to pcolor, and therefore the paths would not be created. This creates the pcolor paths with generic data and then calls set_array() with the proper data after the pcolor has been created to make sure all paths are made first.
greglucas
force-pushed
the
pcolor-nan
branch
from
9aad733 to
4d49ed0
Compare
Contributor
Author
|
Thanks for adding the suggestion in, @QuLogic. I also pushed that same logic above into the pcolormesh section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nan inputs to pcolormesh combined with a wrap would mask out the
data before getting to pcolor, and therefore the paths would not
be created. This creates the pcolor paths with generic data and then
calls set_array() with the proper data after the pcolor has been
created to make sure all paths are made first.
Closes #1845